Dashboard should not show a video link if no video has been uploaded

[carlos-granados]

Current behavior:

If you set videoUploadOnPasses to false, Cypress will not upload a video for successful tests. However, a video link is still shown in the dashboard for these tests and if you click it, you will get a page with the message The media could not be loaded, either because the server or network failed or because the format is not supported

Desired behavior:

If no video was uploaded there should be no video link in the dashboard

Steps to reproduce: (app code and test code)

Set the videoUploadOnPasses option to false and run a successful test. No video will be uploaded. Go to the dashboard and locate this test. It will have a link to play a video. If you click on the link you will get the message posted above

Versions

Cypress 3.1.3

images

This is what we see for a successful test. Notice the video button which can be clicked

Then when the button is pressed, we get this:

[jennifer-shehane]

Have confirmed, this is a bug in the API (or possibly the server) @bahmutov

• Run has configuration {videoUploadOnPasses: false}
• GET to runs and instance return a video in the videos array with all fields present, including a validly formatted url
• GET to the the .mp4 resource itself returns 403 Forbidden

[jennifer-shehane]

There should no longer be links to play a video on passing spec files when videoUploadOnPasses is set to false. This should affect recorded runs from now on.

[carlos-granados]

I can confirm that this is working as expected now. Thanks for fixing it!