Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels in test runner for Support and Documentation icons #3091

Closed
bahmutov opened this issue Jan 8, 2019 · 6 comments
Closed

Add labels in test runner for Support and Documentation icons #3091

bahmutov opened this issue Jan 8, 2019 · 6 comments

Comments

@bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Jan 8, 2019

In test runner window, we only use icons to link to Support and Docs.

screen shot 2019-01-08 at 11 41 16 am

Users probably cannot find these links, but we have enough space - we could just put captions next to each icon

@twosavoie
Copy link
Contributor

@twosavoie twosavoie commented Jan 9, 2019

Hi. This would be my first attempt at contributing to an open source project. I have read your contributor's guide and I would like to help. From what I understand, you would like the words "Support" and "Docs" added to app/nav.jsx in the same way you have "Back" in the same file. Am I correct that I wouldn't need to download Node.js and npm for this? Thank you for your help.

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jan 9, 2019

Instead of wrapping these links with a <Tooltip>, we want to instead place the text inside the link, beside the icon. https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/src/app/nav.jsx#L26

In order to run the desktop-gui package locally, to see these changes, it would require having Node installed as per the Requirements

@twosavoie
Copy link
Contributor

@twosavoie twosavoie commented Jan 9, 2019

Great, I'll take care of it. Thanks for your help.

@twosavoie
Copy link
Contributor

@twosavoie twosavoie commented Jan 9, 2019

I've made the changes and submitted a pull request. If there is something I should have done differently, please let me know.

I noticed that two checks did not pass. One is that Tooltip is specified but not used. Should I have removed it from "import ..." at the top of the file? The other is that the "Record Key" will not work outside of the Electron browser. Is there a change I need to make here?

Thank you for your time and help. This has been my first attempt at contributing to an open source project. Very exciting!

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jan 15, 2019

The code for this is done in #3108, but this has yet to be released. We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Jan 30, 2019

Released in 3.1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants