Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium installed via snap is not available in Cypress #3183

Closed
flotwig opened this Issue Jan 22, 2019 · 5 comments

Comments

4 participants
@flotwig
Copy link
Member

flotwig commented Jan 22, 2019

Current behavior:

If Chromium is installed as a snap (snap install chromium), Cypress won't auto-detect it as a supported browser for testing:

image

Desired behavior:

Make Chromium installed as a snap available for testing without additional configuration, like the docs say: "Cypress automatically detects available browsers on your OS."

Steps to reproduce: (app code and test code)

  1. Install Chromium as a snap
  2. Open the Cypress GUI
  3. Try to use it as a browser

Versions

Cypress: latest develop branch
Ubuntu 18.04.1
Chromium 71 stable from https://snapcraft.io/chromium

Potentially related issues

#1400

@flotwig flotwig changed the title Chromium installed via Chromium installed via snap is not available in Cypress Jan 22, 2019

@flotwig flotwig self-assigned this Jan 22, 2019

@jennifer-shehane jennifer-shehane added this to the Sprint 20 milestone Jan 22, 2019

@flotwig flotwig referenced this issue Jan 23, 2019

Open

Improve browser detection #3202

13 of 14 tasks complete
@flotwig

This comment has been minimized.

Copy link
Member Author

flotwig commented Jan 23, 2019

Seems to be a side-effect of being named chromium instead of chromium-browser. I'll think up a nice way to add lists of binary aliases to the launcher tomorrow.

@flotwig

This comment has been minimized.

Copy link
Member Author

flotwig commented Jan 24, 2019

With support for binary aliases comes the possibility that we'll encounter multiple versions of the same binary. So now the launcher needs to support launching a specific version, at least internally.

@flotwig

This comment has been minimized.

Copy link
Member Author

flotwig commented Jan 24, 2019

I think that, in order to do this, we need to be passing the Browser objects from the launcher around internally. I did some digging and the server pretty much only identifies the current browser by "name" (chrome, chromium, etc...) and this won't do, especially if we want to eventually support arbitrary browser paths being passed in.

@bahmutov

This comment has been minimized.

Copy link
Collaborator

bahmutov commented Jan 24, 2019

@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 15, 2019

Released in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.