Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Represent browsers as `Browser` objects internally #3218

Closed
flotwig opened this Issue Jan 24, 2019 · 1 comment

Comments

3 participants
@flotwig
Copy link
Member

flotwig commented Jan 24, 2019

Current behavior:

Inside the launcher package, browser is treated as an object with a name, a version, a path to the browser...

packages/launcher/lib/types.ts

Inside the server package, the browser is treated as an object (at first), but is quickly reduced to just the name (chrome, chromium, ...)

This means there's not much flexibility in how we can detect different browsers and then pass that information to the rest of Cypress.

Desired behavior:

Modify the internal representation of browsers from just the name to always be the full Browser object, to enable new functionality like selecting browser by version (#3183), using arbitrary paths to browsers (#1026), and using proper display names in the desktop-gui.

@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 15, 2019

Released in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.