Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cy.wrap(undefined).should does not retry #3241

Closed
Bkucera opened this Issue Jan 28, 2019 · 2 comments

Comments

2 participants
@Bkucera
Copy link
Member

Bkucera commented Jan 28, 2019

cy.wrap(undefined).should('eq', true)

should timeout the same way that cy.wrap(null).should('eq', true) does. Currently it will not retry, and only make the assertion once

this is due to us using bluebird's Promise.reduce under the hood to apply assertions, and it will not invoke a callback with undefined

image

@Bkucera Bkucera added the type: bug label Jan 28, 2019

@Bkucera Bkucera self-assigned this Jan 28, 2019

@Bkucera Bkucera changed the title cy.wrap(undefined) does not retry cy.wrap(undefined).should does not retry Jan 29, 2019

@Bkucera Bkucera referenced this issue Jan 29, 2019

Merged

allow .its to yield undefined #3226

3 of 3 tasks complete
@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 15, 2019

The code for this is done in cypress-io/cypress#3226, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 15, 2019

Released in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.