Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected behavior when passing glob pattern for specs #3318

Closed
flotwig opened this Issue Feb 4, 2019 · 2 comments

Comments

2 participants
@flotwig
Copy link
Member

flotwig commented Feb 4, 2019

Current behavior:

It's unclear to new users how they should pass glob patterns to cypress run, mostly because

  • their shell will expand globs - --spec * gets passed as --spec fileA fileB fileC
  • then, Cypress thinks that spec === 'fileA'
    • - unless they use double quotes, in which case Cypress receives "*" and we glob it ourselves (unintuitive)
    • - or if they use --spec=*, which the shell also won't expand, and we glob it ourselves

Passing --spec= will interfere with tab-completion of spec names. Double-quoting the spec names also supposedly interferes with tab-completion of spec names in the shell, though I haven't been able to reproduce this yet

Desired behavior:

  • Accept a space-delimited series of filenames as the spec filenames, so that users can use their shell's built-in globbing when passing a set of spec filenames
    • Currently we accept comma-delimited spec filenames, but shells expand using spaces
  • Potentially warn the user that they are passing a list of filenames to Cypress and not a glob pattern, because passing a long list of filenames will make various GUI elements in dashboard, desktop-gui look funny

Related issues

@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 15, 2019

The code for this is done in cypress-io/cypress#3375, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 15, 2019

Released in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.