supportFile does not work for symlinked paths

[ben8p]

Current behavior:

When supportFile is pointing to a symlinked path we get the error "Your supportFile is set to /whatever/support/index.js/index.js"
Where the "index.js" is repeated

Desired behavior:

supportFile should support symlinked paths

Steps to reproduce: (app code and test code)

• Create the structure "foo/support/index.js"
• Create the a symlink "bar" linking to "foo"
• Set cypress supportFile configuration to "bar/support/index.js"
• Observe the error

Versions

Cypress 3.1.5
Node 11.6.0
Linux Ubuntu 18.04

Additional info

The cause of the problem is

cypress/packages/server/lib/config.coffee

Line 367 in ce3ab55

obj.supportFile = path.join(sf, path.basename(obj.supportFile))

It assume sf is a path and does not contain the filename.

But that is incorrect. sf is resolved to the full path, including index.js.

The line should probably become obj.supportFile = path.join(path.dirname(sf), path.basename(obj.supportFile))

[marielenna]

Hey, I can change this.

[jennifer-shehane]

@Marieram Great! Let us know if you have any questions on contributing.

[tzolnai]

Any progress on this issue? We had the same problem with Cypress 4.5.0.

[cypress-app-bot]

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

[cypress-app-bot]

This issue has been closed due to inactivity.