Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress devtool sometimes loses "developer tools" menu bar item #3559

Closed
tnrich opened this issue Feb 21, 2019 · 17 comments
Closed

Cypress devtool sometimes loses "developer tools" menu bar item #3559

tnrich opened this issue Feb 21, 2019 · 17 comments
Labels
browser: electron pkg/server This is due to an issue in the packages/server directory type: bug

Comments

@tnrich
Copy link
Contributor

tnrich commented Feb 21, 2019

Current behavior:

I'm not sure when this happens but fairly often I'll go to press a shortcut to reload cypress or open the inspector and find that it isn't working. Then I'll see that those options have disappeared from the menubar:

image

Desired behavior:

image

Steps to reproduce: (app code and test code)

I'm not sure when this happens, but maybe someone else who has experienced this issue knows?

Versions

Latest chrome v72
Cypress 3.1.5
Mac OSX

@jennifer-shehane
Copy link
Member

This menu is only available when running Cypress tests on Electron for me. When running through Chrome, the Chrome menubar appears. Are you opening the tests in Electron here?

@jennifer-shehane jennifer-shehane added the stage: needs information Not enough info to reproduce the issue label Feb 22, 2019
@tnrich
Copy link
Contributor Author

tnrich commented Feb 22, 2019

Yep running in electron

@hinfaits
Copy link

I observe this occasionally when running tests in Electron from the Test Runner. I believe when this occurs, the Devtools are also inaccessible through Ctrl+Shift+I (which normally opens the devtools).

Windows 10 / Cypress 3.1.5

@actuallyReallyAlex
Copy link

This happens to me using Electron / Cypress 3.1.5.

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Apr 24, 2019

I think this may be fixed by this PR: #4003 - set to release in 3.3.0

@tnrich
Copy link
Contributor Author

tnrich commented Apr 24, 2019

Whoo! Can you let me know when that lands in a cypress release!?

@lrtanner
Copy link

lrtanner commented May 1, 2019

This bug is present on both Windows and Linux for me on 3.1.5

@jennifer-shehane
Copy link
Member

3.3.0 was released. Has this been fixed you y'all?

@cypress-bot cypress-bot bot added stage: awaiting response Potential fix was proposed; awaiting response and removed stage: needs information Not enough info to reproduce the issue labels May 30, 2019
@actuallyReallyAlex
Copy link

Seems to be fixed for me. Using 3.3.1

@jennifer-shehane jennifer-shehane removed the stage: awaiting response Potential fix was proposed; awaiting response label Jun 3, 2019
@jennifer-shehane
Copy link
Member

jennifer-shehane commented Jun 3, 2019

Released in 3.3.0.

@lukeapage
Copy link
Contributor

@jennifer-shehane can you re-open this?

image

Its intermittent for me, it happens particularly when my system is slowed down e.g. if I run one spec over and over for 20 mins, until its very slow due to memory leaks, then I close the spec and re-open it.

I notice that you seem to be globally adding and removing the menu for developer tools depending on if a spec window is open, so I suspect that as some of this is async, if you process removing the menu after adding a menu, it ends up disappearing.

work around - close the spec window. wait 10 seconds. open it again.

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Jul 18, 2019

Honestly, it's much simpler than this because I just found it looking at your screenshot. The Develop Tools menu disappears in Electron browser after focusing on the "Integration Tests" window, then switching back to the Electron browser window.

Oh great, my screen recording doesn't record my Menu bar. 😝 I think I should be able to fix this.

@jennifer-shehane jennifer-shehane self-assigned this Jul 18, 2019
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jul 18, 2019
@jennifer-shehane jennifer-shehane added type: bug pkg/server This is due to an issue in the packages/server directory browser: electron labels Jul 18, 2019
@lukeapage
Copy link
Contributor

Thanks for the simpler reproduction!

@fr0
Copy link

fr0 commented Feb 4, 2020

This is still happening for me on Cypress 3.8.3, using Mac OS + Electron 78. Activating the Integration Tests window and switching back to the Electron browser window does not help.

@jennifer-shehane jennifer-shehane removed their assignment Apr 29, 2020
@jennifer-shehane
Copy link
Member

This will be fixed in the Electron 9 upgrade #7791

@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Jun 29, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jun 29, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 29, 2020

The code for this is done in cypress-io/cypress#7791, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jun 29, 2020
@jennifer-shehane
Copy link
Member

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v5.0.0, please open a new issue.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: electron pkg/server This is due to an issue in the packages/server directory type: bug
Projects
None yet
Development

No branches or pull requests

7 participants