Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest version of Electron #3568

Open
chrisbreiding opened this issue Feb 22, 2019 · 11 comments

Comments

@chrisbreiding
Copy link
Collaborator

commented Feb 22, 2019

Currently, Cypress uses Electron 1.8.2. The latest stable release is 4.0.5 4.1.3. This will bring along features and breaking changes from 2.x, 3.x, and 4.x. The biggest changes that will affect users are:

As part of this upgrade, we should also enable the right-click context menu in the Electron browser. It was disabled due to an issue in the previous version that caused Cypress to crash, but is likely fixed now.

Related:

@mitar

This comment has been minimized.

Copy link

commented Mar 3, 2019

Do you think you could explore also flags I mention #3633 as you are upgrading to new Electron/Chrome? Since Chrome 65 there is an option --disable-dev-shm-usage which would fix issues when running Cypress inside Docker. I think with upgrade to new Electron this option becomes available.

@benmonro

This comment has been minimized.

Copy link

commented Mar 28, 2019

i got here by clicking on 3 separate issues "closing in favor of <link to 2.0 update>" => "closing in favor of <link to 3.0 update>" => "closing in favor of <link to this 4.x update>"

in the meantime, cypress is using electron browser on version 59. is there any way I can force it to use a newer build of electron?

As it stands right now, I get an error that only seems to happen in older chromium builds: Cookie length should be less than or equal to 4096 characters. from a service I don't control. is there either A) a work around for that or B) a work around for that?

thanks in advance
-Ben

@jennifer-shehane

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@benmonro Please read this issue in response to your question #3228

@benmonro

This comment has been minimized.

Copy link

commented Mar 29, 2019

@jennifer-shehane thank you for that but then I can't run headless in CI right?

@brandonb927

This comment has been minimized.

Copy link

commented Mar 29, 2019

@benmonro You can use the Cypress Docker images in CI for a particular version of Chrome https://github.com/cypress-io/cypress-docker-images

@miniak

This comment has been minimized.

Copy link

commented Apr 1, 2019

I am one of the Electron maintainers. Do you need any help with the update? Electron 1.8 is not supported anymore. You should move to a supported version if possible. Electron 3 (Chromium 66) could be an option as well as it still supports OS X 10.9.

@miniak

This comment has been minimized.

Copy link

commented Apr 1, 2019

You should also target the latest Electron 4 release, which is 4.1.3 at this time, to make sure you have all the latest security fixes.

@bahmutov

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2019

Thank you @miniak for the offer, @chrisbreiding is there a way we can use Milan's expertise to help out?

@chrisbreiding

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 2, 2019

@miniak Any help would be greatly appreciated. I'm incrementally upgrading Electron and working to fix issues along the way. There are many failing tests related to upgrading to Electron 3, a lot because of EPIPE and ECONNRESET errors. Do you have any ideas what could be the root cause?

Thanks for the tip about the latest version. We'll make sure we're on the latest before we get this merged.

@chrisbreiding chrisbreiding changed the title Upgrade to Electron 4.0.5 Upgrade to the latest version of Electron Apr 2, 2019

@miniak

This comment has been minimized.

Copy link

commented Apr 3, 2019

Those failing tests could be caused by upgraded Node.js inside of Electron

@joeljeske

This comment has been minimized.

Copy link

commented May 16, 2019

Any update on this? I would very much like to use the latest version.

@chrisbreiding chrisbreiding referenced this issue May 21, 2019

Open

Cypress v4.0 #4270

10 of 22 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.