Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing fields in VisitOptions Typescript definition #3989

Closed
cm0s opened this issue Apr 17, 2019 · 3 comments
Closed

Missing fields in VisitOptions Typescript definition #3989

cm0s opened this issue Apr 17, 2019 · 3 comments
Assignees

Comments

@cm0s
Copy link

@cm0s cm0s commented Apr 17, 2019

Current behavior:

Current type definition for VisitOptions is missing many fields :

  • method
  • body
  • headers
  • log
  • timeout

Desired behavior:

Being able to call cy.visit() with those options when using typescript

Steps to reproduce: (app code and test code)

cy.visit("my-url", { headers: { foo : 'bar' }});

Versions

Cypress 3.2.0

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Apr 17, 2019

The code for this is done in cypress-io/cypress#3991, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cm0s
Copy link
Author

@cm0s cm0s commented Apr 18, 2019

That was quick! Thanks for taking care of it.

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants