Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show the Cypress error page on network errors #4101

Closed
flotwig opened this issue May 2, 2019 · 2 comments

Comments

2 participants
@flotwig
Copy link
Member

commented May 2, 2019

When a request is proxied through Cypress and there is a network error, currently we send a valid HTML response with a 500 status code:

"Cypress errored attempting to make an http request to this url..."

This causes issues when users expect their applications to behave like the real world.

Current issues include:

  • #1398 - JSON being received as HTML on net error
  • #957 - Cypress tries to inject the HTML mid-response-stream

If we don't send that error anymore, then there's no issue. We should just kill the browser-facing socket and let users handle the network error in application code.


We should still retain the old error for failed file requests, since we stand up a web server for them and can serve 404's or what have you:

Cypress errored trying to serve this file from your system...

@cypress-bot

This comment has been minimized.

Copy link

commented May 17, 2019

The code for this is done in cypress-io/cypress#4105, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot

This comment has been minimized.

Copy link

commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.