Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wide selectors in the selector playground can cause GUI overflow issues #4184

Closed
calvinballing opened this issue May 13, 2019 · 3 comments · Fixed by #8509
Closed

Wide selectors in the selector playground can cause GUI overflow issues #4184

calvinballing opened this issue May 13, 2019 · 3 comments · Fixed by #8509
Labels
good first issue Good for newcomers pkg/runner This is due to an issue in the packages/runner directory type: bug

Comments

@calvinballing
Copy link
Contributor

Current behavior:

Very long selectors in the selector playground text input box can overflow other page elements:
image

Desired behavior:

When some maximum width of the field is reached (based on the browser's width), the user has to scroll to see the rest of the input. Something like this:
https://codepen.io/Momciloo/pen/bpyMbB

Steps to reproduce: (app code and test code)

Type or paste a very long selector in to the selector playground text input box. And yes, I know that using selectors that look like this is not recommended :)

Versions

Cypress 3.2, Windows 10, Chrome

@jennifer-shehane jennifer-shehane added pkg/runner This is due to an issue in the packages/runner directory type: bug difficulty: 1️⃣ good first issue Good for newcomers labels May 14, 2019
@chrisbreiding
Copy link
Contributor

The code for this is done in cypress-io/cypress#8509, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 15, 2020

Released in 5.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers pkg/runner This is due to an issue in the packages/runner directory type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants