Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect CI environment variable from Concourse CI #4376

Closed
jennifer-shehane opened this issue Jun 4, 2019 · 4 comments

Comments

2 participants
@jennifer-shehane
Copy link
Member

commented Jun 4, 2019

Current behavior:

We don't collect anything from a Concourse CI run - do not even know if they are running within Concourse CI

Desired behavior:

Need to identify Concourse and pull any useful environment variables for use here:

https://github.com/cypress-io/cypress/blob/issue-3909/packages/server/lib/util/ci_provider.js

Add environment variables to collect from https://concourse-ci.org/implementing-resource-types.html#resource-metadata

  • $BUILD_ID
  • $BUILD_NAME
  • $BUILD_JOB_NAME
  • $BUILD_PIPELINE_NAME
  • $BUILD_TEAM_NAME
  • $ATC_EXTERNAL_URL

If the build is a one-off, $BUILD_NAME, $BUILD_JOB_NAME, and $BUILD_PIPELINE_NAME will not be set.

I see quite a few other env variables floating around starting with CONCOURSE_, which can probably be used to identify it as a run within Concource CI.

Versions

Cypress 3.3.1

@mster

This comment has been minimized.

Copy link

commented Jun 4, 2019

I'd love to help contribute! :)

@jennifer-shehane

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

@mster Thanks! We would love an open PR - even one that is a work in progress is fine. Check out our contributing doc and ask us if you get stuck.

@cypress-bot

This comment has been minimized.

Copy link

commented Jul 3, 2019

The code for this is done in cypress-io/cypress#4642, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

Released in 3.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.