Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when ProxyMode/ExtensionWhiteList registry setting is detected #4391

Closed
flotwig opened this issue Jun 5, 2019 · 3 comments

Comments

2 participants
@flotwig
Copy link
Member

commented Jun 5, 2019

Cypress fails in strange ways if a ProxyMode policy is set on the user's computer, because it can break Cypress's proxy when running tests in Chrome.

We should:

  • warn the user on the command line when Cypress is launched if we detect this setting
  • maybe also warn the user if they try to launch Chrome with this setting enabled - could have chrome greyed out, or add a small ⚠️ sign or something with a tooltip explaining this problem - also don't set Chrome as the default browser

Relevant issues: #1253 and #4263


Should also detect ExtensionWhiteList/other problematic extension settings.

Relevant issues: #1239, #2494

@wojciechsabaj

This comment has been minimized.

Copy link

commented Jun 6, 2019

@flotwig I fully agree with your decision. The best solution (from user's and UI/UX's point of view) will be adding a small ⚠️ sign before the browser's name. You should also introduce a balloon tip (when ⚠️ is hovered) saying what the problem is, like this:

"We detected ProxyMode key in your registry. Cypress's proxy cannot work properly with Chrome. To fix this issue, please [visit this page | remove the following keys | any other kind of advice that you can give to help people find out what's happening]

You can put a link to one of your pages describing the situation and possible solutions. I think that it is not so good to just tell people "hey, just remove those keys", as some people may have no rights to perform such actions, however, this will be the most straightforward solution.

Hope this helps :) Keep doing a great job with Cypress!

@flotwig flotwig changed the title Warn when ProxyMode registry setting is detected Warn when ProxyMode/ExtensionWhiteList registry setting is detected Jun 6, 2019

@cypress-bot

This comment has been minimized.

Copy link

commented Jul 3, 2019

The code for this is done in cypress-io/cypress#4405, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

Released in 3.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.