Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On cy.visit('file://...) throw err to explain they should visit relative html file #4452

Closed
jennifer-shehane opened this issue Jun 13, 2019 · 2 comments

Comments

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jun 13, 2019

Current behavior:

We've had a couple people try to cy.visit('file://...). We support visiting .html files by specifying the relative path.

Desired behavior:

We can see if the user has passed in a file:// and throw a specific error advising them to pass in the relative path to the file from their projectRoot.

Versions

Cypress 3.3.1

flotwig added a commit that referenced this issue Aug 22, 2019
* #4452 Add a helpful error message for cy.visit()

* #4452 Add note on limitation of baseUrl

* #4452 Minor fix to the error message

Co-Authored-By: Ben Kucera <14625260+Bkucera@users.noreply.github.com>

* #4452 Remove the 2nd paragraph

Co-Authored-By: Ben Kucera <14625260+Bkucera@users.noreply.github.com>

* #4452 Reword the error message

Co-Authored-By: Ben Kucera <14625260+Bkucera@users.noreply.github.com>

* Clean up whitespace; tweak wording
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Aug 22, 2019

The code for this is done in cypress-io/cypress#4982, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

grabartley added a commit to grabartley/cypress that referenced this issue Oct 6, 2019
…o#4982)

* cypress-io#4452 Add a helpful error message for cy.visit()

* cypress-io#4452 Add note on limitation of baseUrl

* cypress-io#4452 Minor fix to the error message

Co-Authored-By: Ben Kucera <14625260+Bkucera@users.noreply.github.com>

* cypress-io#4452 Remove the 2nd paragraph

Co-Authored-By: Ben Kucera <14625260+Bkucera@users.noreply.github.com>

* cypress-io#4452 Reword the error message

Co-Authored-By: Ben Kucera <14625260+Bkucera@users.noreply.github.com>

* Clean up whitespace; tweak wording
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Oct 23, 2019

Released in 3.5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant