Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional values: bearer and sendImmediately are missing in Cypress.Auth interface (TypeScript) #4837

Open
hvuong-sigma opened this issue Jul 26, 2019 · 3 comments

Comments

@hvuong-sigma
Copy link

commented Jul 26, 2019

Current behavior:

The current interface for Auth:

 interface Auth {
    username: string;
    password: string;
  }

Desired behavior:

Both bearer and sendImmediately should be optional props:

  interface Auth {
    username: string;
    password: string;
    bearer?: string;
    sendImmediately?: boolean;
  }

Steps to reproduce: (app code and test code)

Try passing either bearer or sendImmediately as options

Versions

Cypress 3.3.2

@hvuong-sigma hvuong-sigma changed the title Optional values: bearer and sendImmediately are missing in Cypress.Auth interface Optional values: bearer and sendImmediately are missing in Cypress.Auth interface (TypeScript) Jul 26, 2019

@jennifer-shehane

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

@msarfrazanwar

This comment has been minimized.

Copy link

commented Jul 30, 2019

Is it done or can I work on this one ? @hvuong-sigma @jennifer-shehane

@jennifer-shehane

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

@msarfrazanwar You can work on this. Issues are closed when they are done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.