Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use production dependencies in final prod bundle #4844

Closed
kuceb opened this issue Jul 29, 2019 · 3 comments · Fixed by #4842
Closed

use production dependencies in final prod bundle #4844

kuceb opened this issue Jul 29, 2019 · 3 comments · Fixed by #4842
Assignees
@kuceb

Comments

@kuceb
Copy link
Contributor

kuceb commented Jul 29, 2019 •
edited by brian-mann

Ensure we are bundling production version of dependencies such as react, bluebird, react-dom etc

Purpose

  • if we bundle development versions, it hurts bundle size and efficiency(cpu, memory usage) and can conflict with development versions in AUT, for example messing up react devtools
  • additionally, development versions such as react add in internal debug code that holds onto references, which can keep objects around in memory and lead to performance degradation or increased memory / heap size
@kuceb kuceb mentioned this issue Jul 29, 2019
Merged
5 tasks
@kuceb kuceb self-assigned this Jul 29, 2019
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Jul 29, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

The code for this is done in cypress-io/cypress#4842, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 29, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2019

Released in 3.4.1.

@Saibamen
Copy link
Contributor

How much bundle size we saved before and after?

@snyk-bot snyk-bot mentioned this issue Nov 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuceb kuceb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set node_env for production and add static asset tests cypress-io/cypress
2 participants
@Saibamen @kuceb