Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress auto-generated files should have trailing newlines #502

Closed
lorennorman opened this Issue May 16, 2017 · 2 comments

Comments

2 participants
@lorennorman
Copy link
Contributor

lorennorman commented May 16, 2017

Current behavior:

Frequently (not sure if it's every file), when Cypress auto-generates a file for the user, the files do not include trailing newlines. This is an anti-pattern in general, see this discussion, and an added nuisance when using git:

image

and GitHub:

pasted image at 2017_05_16 01_12 pm

Expected behavior:

I expect Cypress to be aware of common idioms and not generate extra work for users.

How to reproduce the current behavior:

Generate files and see what git says! Might be harder to see in CLI since git doesn't get a chance to complain for new files, normally the complaints happen in diffs. GitHub for Mac shows it clearly, though.

  • Operating System: MacOS
  • Cypress Version: 0.19.2
@jennifer-shehane

This comment has been minimized.

Copy link
Member

jennifer-shehane commented Feb 1, 2019

Commit made here to example project. Need to release and update dep within cypress. cypress-io/cypress-example-kitchensink@14c815d

@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 15, 2019

Released in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.