Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6.1 Special characters wrongly displayed in runner UI assertions #5679

Open
gustawx opened this issue Nov 13, 2019 · 5 comments
Open

3.6.1 Special characters wrongly displayed in runner UI assertions #5679

gustawx opened this issue Nov 13, 2019 · 5 comments

Comments

@gustawx
Copy link

@gustawx gustawx commented Nov 13, 2019

Current behavior:

cypress

Desired behavior:

Special characters properly displayed

Steps to reproduce: (app code and test code)

for e.g. use assertion with regex:
should('match', /width: (50.*|49.*|48.*)%;/)

Versions

3.6.1

@jennifer-shehane

This comment has been minimized.

Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 17, 2019

Verified in 3.8.0.

it("prints", () => {
  cy.wrap('foo').should('match', /width: (50.*|49.*|48.*)%;/)
})

Screen Shot 2019-12-17 at 2 26 29 PM

This is due to our Command logging supporting markdown as explained here: #2134 (comment) So is an unfortunate side effect.

@gerardjorgensen

This comment has been minimized.

Copy link

@gerardjorgensen gerardjorgensen commented Dec 17, 2019

Hi, can I work on this?

@jennifer-shehane

This comment has been minimized.

Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 17, 2019

@gerardjorgensen Yes we would love an open PR - even one that is a work in progress is fine. Check out our contributing doc and ask us if you get stuck.

@gerardjorgensen

This comment has been minimized.

Copy link

@gerardjorgensen gerardjorgensen commented Dec 20, 2019

I'm unfortunately stuck figuring out where the special character is converted Markdown. I looked at https://github.com/cypress-io/cypress/blob/develop/packages/reporter/src/commands/command.tsx#L106 but from there I'm not sure where to go.

@jennifer-shehane

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.