Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cy.type accept keyboard shortcut syntax to release modifiers #5694

Closed
kuceb opened this issue Nov 13, 2019 · 2 comments · Fixed by #8499
Closed

cy.type accept keyboard shortcut syntax to release modifiers #5694

kuceb opened this issue Nov 13, 2019 · 2 comments · Fixed by #8499
Labels
pkg/driver topic: cy.type ⌨️ type: enhancement Requested enhancement of existing feature

Comments

@kuceb
Copy link
Contributor

kuceb commented Nov 13, 2019 •
edited

currently, in order to simulate the user pressing "ctrl+bhello world", you would need two cy.type commands if you want to simulate releasing the ctrl key after the b:

cy.get('...').type('{ctrl}b').type('hello world')

We should introduce a new syntax {<mod>+<key>} to specify you want to press-and-release the ctrl key after one (or more) key:

cy.get('...').type('{ctrl+b}hello world')
@sainthkh sainthkh mentioned this issue Aug 25, 2020
Closed
@sainthkh sainthkh assigned sainthkh and unassigned sainthkh Aug 25, 2020
@sainthkh sainthkh mentioned this issue Sep 4, 2020
Merged
3 tasks
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] and removed stage: proposal 💡 No work has been done of this issue labels Sep 4, 2020
@jennifer-shehane jennifer-shehane added the type: enhancement Requested enhancement of existing feature label Oct 6, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress There is an open PR for this issue [WIP] labels Oct 14, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 9, 2020

The code for this is done in cypress-io/cypress#8499, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Nov 9, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 9, 2020

Released in 5.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.6.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Nov 9, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pkg/driver topic: cy.type ⌨️ type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support shortcut syntax in cy.type() sainthkh/cypress
3 participants
@jennifer-shehane @sainthkh @kuceb