Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis PR commit sha is not correctly gathered for status checks with GitHub Integration #5728

Closed
jennifer-shehane opened this issue Nov 18, 2019 · 2 comments · Fixed by #5714

Comments

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Nov 18, 2019

Current behavior:

Cypress associates the PR for the GitHub integration by the commit SHA sent via environment variables from the CI provider. Travis's docs mentions sending these a bit different than other CI providers here:

Rather than build the commits that have been pushed to the branch the pull request is from, we build the merge between the source branch and the upstream branch.
https://docs.travis-ci.com/user/pull-requests/

Currently Cypress looks for TRAVIS_COMMIT, but supplying the TRAVIS_PULL_REQUEST_SHA (https://docs.travis-ci.com/user/environment-variables/) resolves this SHA mixup.

Desired behavior:

A status check for GitHub should run on both commit and PR initiated build from Travis.

Steps to reproduce: (app code and test code)

Some experimenting here: cypress-io/cypress-example-kitchensink#328

Versions

3.6.1

@cypress-bot

This comment has been minimized.

Copy link

@cypress-bot cypress-bot bot commented Nov 18, 2019

The code for this is done in cypress-io/cypress#5714, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot

This comment has been minimized.

Copy link

@cypress-bot cypress-bot bot commented Nov 27, 2019

Released in 3.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.