Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporter message improvements #5773

Closed
sainthkh opened this issue Nov 22, 2019 · 2 comments · Fixed by #7527
Closed

Reporter message improvements #5773

sainthkh opened this issue Nov 22, 2019 · 2 comments · Fixed by #7527
Labels
pkg/reporter This is due to an issue in the packages/reporter directory type: user experience Improvements needed for UX

Comments

@sainthkh
Copy link
Contributor

Current behavior:

This is not a bug. But just some improvements.

In some commands like "get cookies", the words are separated by space in reporter like below:

Screenshot from 2019-11-22 09-58-54

But in other commands like "scrollIntoView", the words are not separated by space and it is a bit hard to read:

Screenshot from 2019-11-22 09-56-01

How about separating the words in these commands?

  • dblclick
  • nextall
  • nextuntil
  • parentsuntil
  • prevall
  • prevuntil
  • readfile
  • rightclick
  • scrollintoview
  • scrollto
  • writefile

Desired behavior:

Separate words of multi-word commands in reporter log.

Steps to reproduce: (app code and test code)

Use those commands and check the log.

Versions

develop branch.

Note

If you allow me, I want to fix this with Object{N} problem in #5762.

@sainthkh sainthkh changed the title Proposal: Reporter message improvements Reporter message improvements Dec 4, 2019
@cypress-bot cypress-bot bot added the stage: proposal 💡 No work has been done of this issue label Dec 4, 2019
@jennifer-shehane jennifer-shehane added type: user experience Improvements needed for UX pkg/reporter This is due to an issue in the packages/reporter directory stage: needs review The PR code is done & tested, needs review and removed stage: proposal 💡 No work has been done of this issue labels Dec 4, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Dec 4, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Dec 16, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress labels Jan 29, 2020
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review The PR code is done & tested, needs review labels Feb 12, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jun 1, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jun 2, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 5, 2020

The code for this is done in cypress-io/cypress#7527, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jun 5, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2020

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/reporter This is due to an issue in the packages/reporter directory type: user experience Improvements needed for UX
Projects
None yet
2 participants