Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration shows env variables as undefined #5859

Closed
stefanzmf opened this issue Dec 3, 2019 · 4 comments · Fixed by #5879 · May be fixed by ngChile/ngx-devkit-cypress-builder#20 or qsays/grafana#1
Closed

Configuration shows env variables as undefined #5859

stefanzmf opened this issue Dec 3, 2019 · 4 comments · Fixed by #5879 · May be fixed by ngChile/ngx-devkit-cypress-builder#20 or qsays/grafana#1
Assignees
Labels
pkg/desktop-gui type: regression v3.7.0 🐛

Comments

@stefanzmf
Copy link

@stefanzmf stefanzmf commented Dec 3, 2019

Settings Panel does not show env variables

Screenshot 2019-12-03 at 14 21 06

cypress/config/foo.json file content

{
  "baseUrl": "http://localhost:8081/",
  "env": {
    "login.email": "foo",
    "login.password": "baz",
    "bar": "bar"
  }
}

Desired behavior:

The Settings panel should show all environments as they are defined in the selected config file.

Steps to reproduce: (app code and test code)

  1. cypress open or cypress open --config-file _PATH_TO_CONFIG_FILE (applies for both, with default or with custom config file)
  2. As soon as the panel shows up, switch to Settings tab (top-left corner)
  3. Open Configuration accordion
  4. env key shows undefined and no source item when hovering

Versions

Node: 12.0.0
Cypress: 3.7.0

Note: Running the exact configuration with cypress 3.6.1 works as expected.

@hermape7
Copy link

@hermape7 hermape7 commented Dec 3, 2019

Have the same issue.

Environment:

  • Node: 10.15.3
  • Cypress: 3.7.0

@cypress-bot cypress-bot bot added the stage: needs investigating label Dec 3, 2019
@jennifer-shehane jennifer-shehane changed the title Configuration shows env variables undefined Configuration shows env variables undefined when set from configFile Dec 3, 2019
@jennifer-shehane jennifer-shehane changed the title Configuration shows env variables undefined when set from configFile Configuration shows env variables as undefined Dec 3, 2019
@jennifer-shehane jennifer-shehane added the type: regression label Dec 3, 2019
@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 3, 2019

I can confirm this is showing as undefined in the Settings panel when set from a custom config-file or from the regular cypress.json file.

The env does properly display in 3.6.0, so this is a regression introduced in 3.7.0.

I have also confirmed that the env variables are being correctly set and are readable from the spec files, so this appears to only be affecting the display in the settings panel (which was redesigned in 3.7.0)

@cypress-bot cypress-bot bot added stage: ready for work and removed stage: needs investigating labels Dec 3, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review and removed stage: ready for work stage: work in progress labels Dec 4, 2019
@jennifer-shehane jennifer-shehane changed the title Configuration shows env variables as undefined Configuration shows env variables as undefined in 3.7.0 Dec 4, 2019
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: needs review labels Dec 6, 2019
@jennifer-shehane jennifer-shehane added the v3.7.0 🐛 label Dec 10, 2019
@jennifer-shehane jennifer-shehane changed the title Configuration shows env variables as undefined in 3.7.0 Configuration shows env variables as undefined Dec 10, 2019
@cypress-bot cypress-bot bot added stage: needs review stage: work in progress and removed stage: work in progress stage: needs review labels Dec 11, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review labels Dec 12, 2019
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Dec 12, 2019

The code for this is done in cypress-io/cypress#5879, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 16, 2019

Released in 3.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/desktop-gui type: regression v3.7.0 🐛
Projects
None yet
4 participants