Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper limit on cy.viewport; investigate removing lower limit #5892

Closed
flotwig opened this issue Dec 5, 2019 · 2 comments · Fixed by #5901
Closed

Remove upper limit on cy.viewport; investigate removing lower limit #5892

flotwig opened this issue Dec 5, 2019 · 2 comments · Fixed by #5901

Comments

@flotwig
Copy link
Member

@flotwig flotwig commented Dec 5, 2019

Current behavior:

cy.viewport has limited bounds (minimum 20px, maximum 8000px)

Desired behavior:

  • cy.viewport has an upper bound of 100k (unlikely to be practically useful, but will prevent users from accidentally entering a billion or something
  • Investigate if it's necessary to protect users with an upper limit - does cy.viewport(1 million, 1 million) actually cause performance issues? If not we can remove the upper limit altogether.
  • Investigate if we need the lower limit - it may be that some applications are suited to a 0x0 viewport, like a pixel tracker that works in an <iframe>.
@cypress-bot

This comment has been minimized.

Copy link

@cypress-bot cypress-bot bot commented Dec 9, 2019

The code for this is done in cypress-io/cypress#5901, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot

This comment has been minimized.

Copy link

@cypress-bot cypress-bot bot commented Dec 12, 2019

Released in 3.8.0.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.