Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using more official browser brand icons #5921

Closed
jennifer-shehane opened this issue Dec 10, 2019 · 1 comment · Fixed by #5991
Closed

Switch to using more official browser brand icons #5921

jennifer-shehane opened this issue Dec 10, 2019 · 1 comment · Fixed by #5991

Comments

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 10, 2019

Current behavior:

Currently we use font awesome 5 free brand icons for browsers.

Our dropdown

Screen Shot 2019-12-10 at 10 12 54 AM

FA available icons

Screen Shot 2019-12-10 at 10 09 51 AM

Desired behavior:

This choice of icons has some downsides:

  1. No separate icon for 'Electron' - using Chrome for Electron browser is likely confusing.
  2. No separate icon for Canary and Chromium, we just have to do static colors.
  3. They don't look as nice as rasterized images would.
  4. They don't keep up with browser branding changes as fast as we could.

Since browsers are a key part of our product, these should probably look nicer.

Screen Shot 2019-12-10 at 10 14 39 AM

Versions

3.7.0

To contribute

@hiramzamorano

This comment has been minimized.

Copy link
Contributor

@hiramzamorano hiramzamorano commented Dec 11, 2019

i'll take a look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.