Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hastily-done decaffeination. #5947

Closed
sainthkh opened this issue Dec 13, 2019 · 2 comments · Fixed by #6045
Closed

Fix hastily-done decaffeination. #5947

sainthkh opened this issue Dec 13, 2019 · 2 comments · Fixed by #6045
Labels
process: code type: chore

Comments

@sainthkh
Copy link
Collaborator

sainthkh commented Dec 13, 2019

In packages/server/lib/util folder, there are some files that are hastily decaffeinated (example). They should be corrected.

Versions

develop branch.
@jennifer-shehane jennifer-shehane added the type: chore label Dec 13, 2019
@cypress-bot cypress-bot bot added the stage: ready for work label Dec 13, 2019
@jennifer-shehane jennifer-shehane added the process: code label Dec 13, 2019
@sainthkh sainthkh mentioned this issue Dec 26, 2019
Merged
1 task
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work labels Dec 26, 2019
@cypress-bot
Copy link

cypress-bot bot commented Dec 27, 2019

The code for this is done in cypress-io/cypress#6045, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: work in progress labels Dec 27, 2019
@cypress-bot
Copy link

cypress-bot bot commented Jan 10, 2020

Released in 3.8.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v3.8.2, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release label Jan 10, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
process: code type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hastily-done decaffs. sainthkh/cypress
2 participants
@jennifer-shehane @sainthkh