Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tests" button fails to take user back to specs list #5948

Closed
wojciech-sygier opened this issue Dec 13, 2019 · 6 comments · Fixed by #7425
Closed

"Tests" button fails to take user back to specs list #5948

wojciech-sygier opened this issue Dec 13, 2019 · 6 comments · Fixed by #7425
Labels
browser: chrome good first issue Good for newcomers pkg/reporter type: regression A bug that didn't appear until a specific Cy version release v3.8.0 🐛 Issue present since 3.8.0

Comments

@wojciech-sygier
Copy link

wojciech-sygier commented Dec 13, 2019

Current behavior:

Clicking "< Tests" button does nothing, only plays animation showing that the button was clicked.

Desired behavior:

User is taken back to the tests/specs list in the Cypress UI.

Steps to reproduce: (app code and test code)

App and test code not included, you can test it with basically anything you want.

  1. Start Cypress.
  2. Run any spec.
  3. Stop the test's execution.
  4. Click "< Tests" button".

Additional information

Console doesn't seem to be returning any error or anything. Typical regression for me.

Media

https://streamable.com/ocfhs

Versions

Introduced in Cypress 3.8.0. I'm using macOS Catalina 10.15.1. Worked fine on Cypress 3.7.0.

@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Dec 13, 2019
@jennifer-shehane jennifer-shehane added type: regression A bug that didn't appear until a specific Cy version release pkg/reporter browser: chrome and removed stage: ready for work The issue is reproducible and in scope labels Dec 13, 2019
@jennifer-shehane
Copy link
Member

@ThisIsJesus I have confirmed the < Tests button does not bring the 'tests' window into focus in 3.8.0 when run in Chrome 78 (which is weird, I thought for sure it would be in Electron). This does work in 3.7.0.

3.7.0 Chrome

3.8.0 Chrome

@jennifer-shehane jennifer-shehane added the v3.8.0 🐛 Issue present since 3.8.0 label Dec 13, 2019
@wojciech-sygier
Copy link
Author

@jennifer-shehane Ah shoot, I completely forgot to mention what browser I was using. Silly me. :( Well then, Chrome 79 is also affected (this is the one I am using), can't really say how it looks on older versions though.

@oleksiydubovykTR
Copy link

Same in Firefox 75

@jennifer-shehane
Copy link
Member

I traced through the code to find that clicking on the button eventually goes to call win.focus() of the Browser Window.

https://github.com/cypress-io/cypress/blob/develop/packages/server/lib/modes/interactive.js#L105:L105

I think this is likely due to the Electron upgrade that was done in 3.8.0, but would have to dig deeper on why us calling the focus on the Electron Desktop-GUI window is not focusing the window. #5849

@jennifer-shehane jennifer-shehane changed the title "Tests" button in every spec fails to take user back to specs list "Tests" button fails to take user back to specs list May 18, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress There is an open PR for this issue [WIP] and removed stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review labels May 20, 2020
@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels May 27, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 27, 2020

The code for this is done in cypress-io/cypress#7425, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2020

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Jun 8, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
browser: chrome good first issue Good for newcomers pkg/reporter type: regression A bug that didn't appear until a specific Cy version release v3.8.0 🐛 Issue present since 3.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants