Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

width/height 0 and transform + overflow hidden #6093

Closed
sainthkh opened this issue Jan 6, 2020 · 1 comment · Fixed by #5916
Closed

width/height 0 and transform + overflow hidden #6093

sainthkh opened this issue Jan 6, 2020 · 1 comment · Fixed by #5916

Comments

@sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Jan 6, 2020

Current behavior:

When an element has width or height 0px with non-none transform and overflow hidden, it is not visible. But isHidden() cannot detect it.

<!-- Example -->
<div style="height: 0px; transform: translate(1, 2)"><p>Visible</p></div>
<div style="height: 0px; transform: translate(1, 2); overflow: hidden"><p>Invisible</p></div>

It is found with cypress-example-piechopper in https://circleci.com/gh/cypress-io/cypress-test-example-repos/71863.

Desired behavior:

isHidden() should detect it.

Steps to reproduce: (app code and test code)

  1. Download https://github.com/cypress-io/cypress-example-piechopper.
  2. Change cypress to dev version.
  3. Run app_spec.js
  4. "displays hamburger menu" fails.

Versions

After #6000 is merged.

@cypress-bot

This comment has been minimized.

Copy link

@cypress-bot cypress-bot bot commented Jan 7, 2020

The code for this is done in cypress-io/cypress#5916, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.