Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+F to set focus on the search bar #6229

Open
Regnander opened this issue Jan 23, 2020 · 8 comments · May be fixed by #6325
Open

Ctrl+F to set focus on the search bar #6229

Regnander opened this issue Jan 23, 2020 · 8 comments · May be fixed by #6325

Comments

@Regnander
Copy link

@Regnander Regnander commented Jan 23, 2020

Current behavior:

Pressing Ctrl+F does nothing at the moment as this keybinding seems not be bound to anything.

Desired behavior:

I want said keybinding to set focus on the search bar in the GUI (and select all existing text), since I'm using the search bar quite often to find files.

Test code to reproduce

N/A

Versions

3.8.2 and older

@jennifer-shehane

This comment has been minimized.

Copy link
Member

@jennifer-shehane jennifer-shehane commented Jan 24, 2020

Hey @Regnander Can you be more specific about where you're like to use ctrl+f? There are several parts to our application and I'm not sure where you're trying to use it.

Also, what browser are you running in if you want this within the area that logs the commands?

Here?

Screen Shot 2020-01-24 at 5 12 33 PM

Here?

Screen Shot 2020-01-24 at 5 12 44 PM

@Regnander

This comment has been minimized.

Copy link
Author

@Regnander Regnander commented Jan 24, 2020

Screen Shot 2020-01-24 at 5 12 33 PM

I meant this window. Sorry about that!

@Manuel-Suarez-Abascal

This comment has been minimized.

Copy link
Contributor

@Manuel-Suarez-Abascal Manuel-Suarez-Abascal commented Feb 1, 2020

@jennifer-shehane @Regnander I would like to give it a go. Can you please guide me on where to find the related file to implement the enhancement? I would like to know which implementation do you have in mind?

@Regnander

This comment has been minimized.

Copy link
Author

@Regnander Regnander commented Feb 3, 2020

I would like to know which implementation do you have in mind?

I don't quite follow. Do you want me to elaborate my suggestion?

@Manuel-Suarez-Abascal

This comment has been minimized.

Copy link
Contributor

@Manuel-Suarez-Abascal Manuel-Suarez-Abascal commented Feb 3, 2020

I would like to know which implementation do you have in mind?

I don't quite follow. Do you want me to elaborate my suggestion?

@Regnander no, it's good. I understand the problem. It's more about implementation, if you guys are thinking a particular approach on how to implement the feature. If not, I would go ahead & start implementing the functionality.

@Manuel-Suarez-Abascal

This comment has been minimized.

Copy link
Contributor

@Manuel-Suarez-Abascal Manuel-Suarez-Abascal commented Feb 4, 2020

@jennifer-shehane is this cypress\packages\desktop-gui\src\specs\specs-list.jsx the file related to the input search? If so, why I'm not able to see changes when I modify the file?

EDIT:
Nevermind, I'm able to see the changes now ;)

@jennifer-shehane

This comment has been minimized.

Copy link
Member

@jennifer-shehane jennifer-shehane commented Feb 4, 2020

@Manuel-Suarez-Abascal Yes, that's the right file with the corresponding tests in Cypress found here: https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/cypress/integration/specs_list_spec.js#L1:L1

There is a Contributing guide that covers how to contribute and get Cypress running locally in generally here: https://github.com/cypress-io/cypress/blob/develop/.github/CONTRIBUTING.md

To run the tests:

  • within cypress root, run npm i
  • cd to cypress/packages/desktop-gui and run npm run watch
  • In cypress/packages/desktop-gui run npm run cypress:open
  • click on the test you're writing to run it within Cypress

Instructions for running the desktop-gui tests can always be found here: https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/README.md

@Manuel-Suarez-Abascal

This comment has been minimized.

Copy link
Contributor

@Manuel-Suarez-Abascal Manuel-Suarez-Abascal commented Feb 5, 2020

@jennifer-shehane @Regnander I have created a PR for this feature here! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.