Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of integration specs gives no indication it can be or is collapsed #6277

Closed
bahmutov opened this issue Jan 30, 2020 · 9 comments · Fixed by #6538
Closed

List of integration specs gives no indication it can be or is collapsed #6277

bahmutov opened this issue Jan 30, 2020 · 9 comments · Fixed by #6538
Labels

Comments

@bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Jan 30, 2020

Cypress 3.8.3

You can click on "Integration tests" heading

Screen Shot 2020-01-30 at 11 02 28 AM

which closes the file tree - and you have no idea that it was collapsed and can be opened. Surprised me once when I did not see any specs and was like ... where are they?!

Screen Shot 2020-01-30 at 11 02 11 AM

Need some kind of icon next to it.

@flotwig
Copy link
Member

@flotwig flotwig commented Jan 30, 2020

This bothers me too! Are there other sections that are possible besides "Integration Tests", currently? If not, we should just remove the ability to collapse the section altogether.

@bahmutov
Copy link
Contributor Author

@bahmutov bahmutov commented Jan 30, 2020

I think we need to allow collapsible behavior because soon we will have component tests tab (and maybe front-end unit tests, and API tests)

@flotwig
Copy link
Member

@flotwig flotwig commented Jan 30, 2020

Okay, can we disable collapsibility if the user only has 1 type of tests?

@bahmutov
Copy link
Contributor Author

@bahmutov bahmutov commented Jan 30, 2020

@cypress-bot cypress-bot bot added the stage: ready for work label Feb 4, 2020
@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Feb 4, 2020

Code for folder display here (the Integration Folder displays with class level-0 basically):

https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/src/specs/specs-list.jsx#L130:L130

Styles for the level-0 folder:

https://github.com/cypress-io/cypress/blob/develop/packages/desktop-gui/src/specs/specs.scss#L145:L145

@alti21
Copy link

@alti21 alti21 commented Feb 6, 2020

Can I try to fix this issue?

@netochaves
Copy link
Contributor

@netochaves netochaves commented Feb 23, 2020

Hey guys, something like this?
image
image

The implementations was already done. I just changed the display of none to block. I'll add some tests and open a PR.

@cypress-bot cypress-bot bot added stage: work in progress stage: needs review and removed stage: ready for work stage: work in progress stage: needs review labels Feb 23, 2020
@cypress-bot cypress-bot bot added stage: needs review and removed stage: work in progress labels Mar 16, 2020
@cypress-bot cypress-bot bot added the stage: pending release label Mar 16, 2020
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Mar 16, 2020

The code for this is done in cypress-io/cypress#6538, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review label Mar 16, 2020
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Mar 16, 2020

Released in 4.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.2.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release label Mar 16, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants