Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle better cache list if there are no binaries installed #6303

Closed
bahmutov opened this issue Feb 3, 2020 · 3 comments · Fixed by #9023
Closed

Handle better cache list if there are no binaries installed #6303

bahmutov opened this issue Feb 3, 2020 · 3 comments · Fixed by #9023
Assignees
@jennifer-shehane
Labels
cli type: error message

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Feb 3, 2020 •
edited by sync-by-unito bot

Cypress v3.8.3 on CI

If we skill installing Cypress binary with CYPRESS_INSTALL_BINARY: 0 env variable, then cypress cache path returns a folder name, but the folder does not exist. Then cypress cache list throws an error, yet exits with 0

https://github.com/bahmutov/cypress-gh-action-split-install/runs/423294744?check_suite_focus=true

Proposal

cypress cache list should show a good warning message if the cache folder does not exist. It should still exit with zero code since there might not be any versions installed
@bahmutov bahmutov added the cli label Feb 3, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Feb 4, 2020
@jennifer-shehane jennifer-shehane mentioned this issue Oct 29, 2020
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress There is an open PR for this issue [WIP] labels Oct 29, 2020
@jennifer-shehane
Copy link
Member

PR opened here to resolve this: #9023

@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review and removed stage: needs review The PR code is done & tested, needs review stage: work in progress There is an open PR for this issue [WIP] labels Oct 29, 2020
@cypress-bot cypress-bot bot added the stage: pending release There is a closed PR for this issue label Oct 30, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 30, 2020

The code for this is done in cypress-io/cypress#9023, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: work in progress There is an open PR for this issue [WIP] label Oct 30, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 9, 2020

Released in 5.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.6.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Nov 9, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jennifer-shehane jennifer-shehane

Labels
cli type: error message
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Show better error message during cypress cache list when no cache cypress-io/cypress
2 participants
@jennifer-shehane @bahmutov