Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{log:false} of clearLocalStorage doesn't work. #6342

Closed
sainthkh opened this issue Feb 6, 2020 · 5 comments · Fixed by #6495 · May be fixed by rangle/test-automation#29
Closed

{log:false} of clearLocalStorage doesn't work. #6342

sainthkh opened this issue Feb 6, 2020 · 5 comments · Fixed by #6495 · May be fixed by rangle/test-automation#29
Labels
good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory type: bug

Comments

@sainthkh
Copy link
Contributor

sainthkh commented Feb 6, 2020 •
edited by jennifer-shehane

Current behavior:

cy.clearLocalStorage({log:false}) should not show the command on the reporter. But it does.

Desired behavior:

It should not show the command.

Test code to reproduce

it('test', () => {
  cy.clearLocalStorage({log:false})
})

Result:

Screenshot from 2020-02-06 15-42-33

Versions

3.8.3
@sainthkh sainthkh added good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory type: bug stage: ready for work The issue is reproducible and in scope labels Feb 6, 2020
@Jelijah
Copy link

Jelijah commented Feb 9, 2020

Hello, I would like to work on this bug. Am I able to start working on this? What is required?

@sainthkh
Copy link
Contributor Author

Just go on and submit a PR. Here's the guide.

If you have anything to ask, feel free to do it.

maddhruv added a commit to maddhruv/cypress that referenced this issue Feb 18, 2020
@maddhruv
fix: disable log for clearLocalStorage cypress-io#6342
d7fea43
@maddhruv maddhruv mentioned this issue Feb 18, 2020
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Feb 18, 2020
@maddhruv
Copy link
Contributor

@sainthkh raised a PR here - #6495

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Feb 18, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Feb 26, 2020
chrisbreiding added a commit that referenced this issue Feb 26, 2020
@maddhruv @brian-mann
@flotwig @chrisbreiding
fix: Implement { log: false } for clearLocalStorage Issue #6342 (#6495)
62dd438 
* fix: disable log for clearLocalStorage #6342

* fix: default log value

* fix: remove unwanted isnt false and options._log

* test: add test for log: false

* feat: add options fallback to keys param

* feat: add options fallback to keys param

* test: add test for key to be options

* test: fix not string error test

Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Co-authored-by: Zach Bloomquist <github@chary.us>
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 26, 2020

The code for this is done in cypress-io/cypress#6495, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Feb 26, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 28, 2020

Released in 4.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory type: bug
Projects
None yet
Milestone
No milestone
3 participants
@sainthkh @maddhruv @Jelijah