Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Node.js 8 during cypress install #6574

Closed
jennifer-shehane opened this issue Feb 27, 2020 · 2 comments · Fixed by #7650
Closed

Remove support for Node.js 8 during cypress install #6574

jennifer-shehane opened this issue Feb 27, 2020 · 2 comments · Fixed by #7650
Labels
cli type: breaking change Requires a new major release version

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Feb 27, 2020

Current behavior:

Cypress currently supports installation using Node.js 8.0.0+

This has caused some headache on our side as we have had to downgrade some of our dependencies to ensure we're supporting Node.js 8.

It also causes issues when users may use a cypress plugin that doesn't support Node.js 8:

Desired behavior:

Truthfully, we haven't even had any outside users report the errors on install of Cypress, so I don't even think anyone is using Node.js 8.0.0 (although Node.js 8 latest may be a different story).

Additionally, Node.js 8 reached end of life Dec 31, 2019: https://nodejs.org/en/about/releases/

We should remove support for Node.js 8 during cypress install and support Node.js 10.0.0 as a minimum.

Node.js 10 end of life is scheduled for April 30, 2021, so a long ways out now.

Versions

Cypress 4.0.2

@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Feb 27, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Feb 27, 2020
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Jun 10, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: pending release and removed stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jun 26, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 30, 2020

The code for this is done in cypress-io/cypress#7650, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cli type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant