Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running cypress verify always logs 'It looks like this is your first time using Cypress: x.x.x' #6607

Closed
jennifer-shehane opened this issue Mar 2, 2020 · 2 comments · Fixed by #6640
Assignees
Labels
cli type: unexpected behavior User expected result, but got another

Comments

@jennifer-shehane
Copy link
Member

Current behavior:

When running cypress verify, it always logs the message below (even though this is maybe my 100th time using Cypress of this version.

$ cypress verify
It looks like this is your first time using Cypress: 3.8.3

 ✔  Verified Cypress! /Users/jennifer/Library/Caches/Cypress/3.8.3/Cypress.app

Desired behavior:

This is misleading - and seems like Cypress does not know what it's checking for.

Test code to reproduce

Run cypress verify on any project that you've already installed Cypress version on and ran it multiple times.

I believe this is naively printing - expecting it to only be run during install when it needs to be verified, but we force verification when running cypress verify command - so this message should be skipped.

cypress verify logs

  cypress:cli Found binary version 3.8.3 installed in: /Users/jennifer/Library/Caches/Cypress/3.8.3/Cypress.app +2ms
  cypress:cli { verified: true } +3ms
  cypress:cli is Verified ? true +1ms
  cypress:cli force verify +0ms

We shouldn't log this message if options.force is true

Versions

Cypress 4.0.2

@jennifer-shehane jennifer-shehane self-assigned this Mar 2, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Mar 2, 2020
@jennifer-shehane jennifer-shehane added type: unexpected behavior User expected result, but got another cli labels Mar 2, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope labels Mar 9, 2020
@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Mar 16, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 16, 2020

The code for this is done in cypress-io/cypress#6640, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 16, 2020

Released in 4.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.2.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Mar 16, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cli type: unexpected behavior User expected result, but got another
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant