Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show separate specs tree view for integration vs component specs #6968

Closed
bahmutov opened this issue Apr 8, 2020 · 3 comments · Fixed by #5923
Closed

Show separate specs tree view for integration vs component specs #6968

bahmutov opened this issue Apr 8, 2020 · 3 comments · Fixed by #5923

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Apr 8, 2020

This is for #5923 (component testing)

against branch issue-5922-mountMode

Example project with integration and component tests https://github.com/bahmutov/test-mdx-example (clone and install dependencies)

To run the example project, switch Cypress monorepo to issue-5922-mountMode, run yarn to install dependencies and build, and then use

yarn start --project <path to test-md-example folder>

If I print specs received by the Desktop GUI specs.integration like this

import ipc from '../lib/ipc'
import specsStore from './specs-store'

const getSpecs = (setProjectError) => {
  const DEFAULT_SPECS = {
    integration: [],
  }

  ipc.getSpecs((err, specs = DEFAULT_SPECS) => {
    if (err) {
      return setProjectError(err)
    }

    console.log('specs')
    console.table(specs.integration)

    specsStore.setSpecs(specs)
  })
}

The list shows specType property

Screen Shot 2020-04-08 at 3 11 20 PM

I think we should separate integration specs from component specs, but could not figure out how to do this in specs jsx file. Probably something like this would be nice

Screen Shot 2020-04-08 at 3 11 20 PM

@bahmutov
Copy link
Contributor Author

bahmutov commented Apr 9, 2020

Current work
Screen Shot 2020-04-09 at 9 17 46 AM

@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Apr 9, 2020
@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Apr 26, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 26, 2020

The code for this is done in cypress-io/cypress#5923, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 28, 2020

Released in 4.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.5.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Apr 28, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant