Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra css spacing below Desktop GUI menu #7023

Closed
jennifer-shehane opened this issue Apr 16, 2020 · 5 comments · Fixed by #7024 or #7056
Closed

Extra css spacing below Desktop GUI menu #7023

jennifer-shehane opened this issue Apr 16, 2020 · 5 comments · Fixed by #7024 or #7056
Assignees
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: user experience Improvements needed for UX

Comments

@jennifer-shehane
Copy link
Member

Current behavior:

There's some extra css spacing below the menu

Screen Shot 2020-04-15 at 10 18 01 PM

Desired behavior:

Menu shouldn't have extra spacing below.

Versions

4.4.0

@jennifer-shehane jennifer-shehane added pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory stage: ready for work The issue is reproducible and in scope type: user experience Improvements needed for UX labels Apr 16, 2020
@jennifer-shehane jennifer-shehane self-assigned this Apr 16, 2020
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Apr 16, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Apr 17, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 17, 2020

The code for this is done in cypress-io/cypress#7024, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@chrisbreiding
Copy link
Contributor

Re-opening because I realized I undertested the work I did on this and broke more than I fixed. So much so a gif is needed to show it 😓

desktop-gui-css-issues

I'll open a new PR with fixes.

@chrisbreiding chrisbreiding reopened this Apr 17, 2020
@jennifer-shehane
Copy link
Member Author

Sorry, I should have retested your changes. 😞

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Apr 17, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Apr 20, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 20, 2020

The code for this is done in cypress-io/cypress#7056, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 20, 2020

Released in 4.4.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.4.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: user experience Improvements needed for UX
Projects
None yet
2 participants