Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cypress 4.6.0 is not consistently showing address bar/viewport is resizing #7443

Closed
danreale opened this issue May 21, 2020 · 8 comments · Fixed by #7448
Closed
Labels
pkg/runner type: regression A bug that didn't appear until a specific Cy version release v4.6.0 🐛 Issue present since 4.6.0

Comments

@danreale
Copy link

Current behavior:

When running a test with cypress 4.6.0, I am noticing that that address bar is showing when the test starts and then disappearing shortly after.
I am also noticing the view port is resizing and not showing the whole application while the tests run through. I was on version 4.4.1 prior to uploading (didnt see these issues), so I am not sure if this issue was present on 4.5.0.

Desired behavior:

I would expect the address bar would always show during a test and that the page doesnt resize/ stays the same size during the test run.

May-21-2020 09-53-17_6

Test code to reproduce

Versions

4.6.0
mac (high sierra 10.13.6)
chrome and edge browsers (did not try others)

@Jacek-fstack
Copy link

+1 it's gone for me as well

@jennifer-shehane
Copy link
Member

jennifer-shehane commented May 21, 2020

I bet this is due to #7203

@jennifer-shehane jennifer-shehane added pkg/reporter type: regression A bug that didn't appear until a specific Cy version release labels May 21, 2020
@danreale
Copy link
Author

@jennifer-shehane would this be slated for the next release?

@ragu2807
Copy link

ragu2807 commented May 21, 2020

Yeah, I can see the same issue with v4.6.0 whereas 4.5.0 looks good.

OS: macOS Mojave 10.14.6
Browsers: Chrome, Edge, Firefox and Electron

Noticed this happens when Cypress scrolls to an element that is not visible within the specified viewport, although it scrolls to the element correctly.

@jennifer-shehane
Copy link
Member

I was able to recreate this with the following code. I also have to run this code in combination with resizing the main browser window to touch either the width/height of the AUT iframe. So if my browser window is really maxed out - you won't see it.

index.html

<html>
<body>
<p style="height: 2000;">Aenean lacinia bibendum nulla sed consectetur.</p>
<footer>Aenean lacinia bibendum nulla sed consectetur.</footer>
</body>
</html>

spec.js

it('test', () => {
  cy.visit('index.html')
  cy.get('footer').click()
})

@jennifer-shehane
Copy link
Member

Reverting #7203 fixes the issue. Will go ahead and revert and reopen the other issue this was fixing since this affects more people.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 26, 2020

The code for this is done in cypress-io/cypress#7448, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 26, 2020

Released in 4.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.7.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label May 26, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/runner type: regression A bug that didn't appear until a specific Cy version release v4.6.0 🐛 Issue present since 4.6.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants