Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign code frame file path #7499

Closed
chrisbreiding opened this issue May 27, 2020 · 2 comments · Fixed by #7502
Closed

Redesign code frame file path #7499

chrisbreiding opened this issue May 27, 2020 · 2 comments · Fixed by #7502
Assignees
@chrisbreiding @panzarino
Labels
pkg/reporter

Comments

@chrisbreiding
Copy link
Contributor

Redesign the code frame file path with the following criteria:

  • Code frame file path has a background color of #f6f6f6
  • File icon appears to the left of the file path
  • File path is centered vertically in the div
  • File path has a hover state where the path is underlined
@chrisbreiding chrisbreiding mentioned this issue May 27, 2020
Closed
1 task
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review stage: ready for work The issue is reproducible and in scope and removed stage: needs review The PR code is done & tested, needs review stage: work in progress There is an open PR for this issue [WIP] labels May 27, 2020
@chrisbreiding chrisbreiding mentioned this issue May 27, 2020
Merged
1 task
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: work in progress There is an open PR for this issue [WIP] and removed stage: ready for work The issue is reproducible and in scope stage: needs review The PR code is done & tested, needs review labels May 27, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 28, 2020

The code for this is done in cypress-io/cypress#7502, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: work in progress There is an open PR for this issue [WIP] labels May 28, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2020

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Jun 8, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrisbreiding chrisbreiding

@panzarino panzarino

Labels
pkg/reporter
Projects
None yet
Milestone
No milestone
2 participants
@chrisbreiding @panzarino