Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress.automation is missing from TypeScript types #7519

Closed
aidanxyz opened this issue May 28, 2020 · 4 comments · Fixed by #7573
Closed

Cypress.automation is missing from TypeScript types #7519

aidanxyz opened this issue May 28, 2020 · 4 comments · Fixed by #7573
Labels
type: typings Issue related to Cypress types (for TypeScript)

Comments

@aidanxyz
Copy link

Current behavior:

Cypress.automation is missing from cypress TypeScript types.

Desired behavior:

Cypress.automation should be present in types.
@jennifer-shehane jennifer-shehane added the type: typings Issue related to Cypress types (for TypeScript) label May 29, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label May 29, 2020
@sainthkh
Copy link
Contributor

sainthkh commented Jun 1, 2020

This doc says that automation events are for internal use.

Could you tell us when it is necessary?

@cypress-bot cypress-bot bot added stage: awaiting response Potential fix was proposed; awaiting response and removed stage: ready for work The issue is reproducible and in scope labels Jun 1, 2020
@aidanxyz
Copy link
Author

aidanxyz commented Jun 2, 2020 •
edited

I made a custom command using the approach from #6932 where it was suggested to make a plugin, which would also require this type definition. Needed for testing offline features in Chrome.

@sainthkh sainthkh mentioned this issue Jun 3, 2020
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review and removed stage: awaiting response Potential fix was proposed; awaiting response stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review labels Jun 3, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 4, 2020

The code for this is done in cypress-io/cypress#7573, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jun 4, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2020

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: typings Issue related to Cypress types (for TypeScript)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type for Cypress.automation sainthkh/cypress
3 participants
@aidanxyz @jennifer-shehane @sainthkh