Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly formatted log message for "have.all.keys" assertion #753

Closed
bahmutov opened this issue Oct 17, 2017 · 3 comments · Fixed by #5619 · May be fixed by ngChile/ngx-devkit-cypress-builder#20 or qsays/grafana#1
Closed

Incorrectly formatted log message for "have.all.keys" assertion #753

bahmutov opened this issue Oct 17, 2017 · 3 comments · Fixed by #5619 · May be fixed by ngChile/ngx-devkit-cypress-builder#20 or qsays/grafana#1

Comments

@bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Oct 17, 2017

All versions of Cypress when making this assertion

it('expect - assert shape of an object', function(){
  const person = {
    name: 'Joe',
    age: 20
  }
  expect(person).to.have.all.keys('name', 'age')
})

Look at the reporter message - looks very weird

have all keys

I added example test to cypress-io/cypress-example-kitchensink#17

@bahmutov bahmutov self-assigned this Oct 17, 2017
@cypress-bot cypress-bot bot added the stage: ready for work label Feb 19, 2019
@jennifer-shehane jennifer-shehane added difficulty: 1️⃣ stage: ready for work and removed stage: ready for work labels Feb 19, 2019
@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jul 12, 2019

I thought this formatting may have improved in v4.0 branch of Cypress with Chai upgrade, but it hasn't. This is still an issue in 3.4.0

@cypress-bot cypress-bot bot added stage: work in progress stage: needs review and removed stage: ready for work stage: work in progress stage: needs review labels Nov 7, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: work in progress labels Nov 12, 2019
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Nov 12, 2019

The code for this is done in cypress-io/cypress#5619, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-io cypress-io deleted a comment from cypress-bot bot Nov 25, 2019
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Nov 27, 2019

Released in 3.7.0.

@cypress-bot cypress-bot bot removed the stage: pending release label Nov 27, 2019
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.