Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stack trace to below code frame #7563

Closed
panzarino opened this issue Jun 2, 2020 · 2 comments · Fixed by #7564
Closed

Move stack trace to below code frame #7563

panzarino opened this issue Jun 2, 2020 · 2 comments · Fixed by #7564
Assignees
@panzarino
Labels
pkg/reporter type: user experience Improvements needed for UX

Comments

@panzarino
Copy link
Contributor

  • Below the code frame should be a div where View Stack Trace accordion will live
    • The div will be split for View Stack Trace and Print to Console
      • The View Stack Trace area will take up the majority of the row of the div
    • View Stack Trace will appear on the left side of the div
      • Hover state background color should be #fee0e3
    • Print to console will appear on the right side
      • Remove tooltip on print to console icon that exists currently
      • Hover state background color should be #fee0e3
    • Background color of the div should be #ffeaec

Desired results:

Screen Shot 2020-06-02 at 12 55 03 AM
@panzarino panzarino added pkg/reporter type: user experience Improvements needed for UX labels Jun 2, 2020
@panzarino panzarino self-assigned this Jun 2, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jun 2, 2020
@panzarino panzarino mentioned this issue Jun 2, 2020
Merged
3 tasks
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review labels Jun 2, 2020
@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Jun 4, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 4, 2020

The code for this is done in cypress-io/cypress#7564, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2020

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Jun 8, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@panzarino panzarino

Labels
pkg/reporter type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move stack trace below code frame in runner cypress-io/cypress
1 participant
@panzarino