Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element highlights not visible on certain position:absolute elements #7762

Closed
kuceb opened this issue Jun 19, 2020 · 3 comments · Fixed by #7763
Closed

Element highlights not visible on certain position:absolute elements #7762

kuceb opened this issue Jun 19, 2020 · 3 comments · Fixed by #7763
Labels
type: bug

Comments

@kuceb
Copy link
Contributor

kuceb commented Jun 19, 2020

Element dom highlights can render underneath position:absolute and fixed elements due to the outer highlight container not having position: absolute and a high z-index
@kuceb kuceb changed the title Element highlights do not render on certain position:absolute elements Element highlights not visible on certain position:absolute elements Jun 19, 2020
@kuceb kuceb mentioned this issue Jun 19, 2020
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review and removed stage: work in progress There is an open PR for this issue [WIP] labels Jun 19, 2020
@jennifer-shehane
Copy link
Member

Reproducible example:

index.html

<!DOCTYPE html>
<html>
<body>
<div id="absolute-el" style="position: absolute;
  z-index: 1000;
  top: 0;
  left: 0;
  height: 50px;
  width: 50px;
  padding: 20px;
  margin: 20px;
  background-color: salmon;"></div>
</body>
</html>

spec.js

it('highlight', () => {
  cy.visit('index.html')
  cy.get('div')
})

@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Jun 22, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 22, 2020

The code for this is done in cypress-io/cypress#7763, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 23, 2020

Released in 4.9.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.9.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Jun 23, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix dom-highlights rendering under absolute position elements cypress-io/cypress
2 participants
@jennifer-shehane @kuceb