Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout progress bar reset when hooks collapsed #7912

Closed
panzarino opened this issue Jul 8, 2020 · 2 comments · Fixed by #7923
Closed

Timeout progress bar reset when hooks collapsed #7912

panzarino opened this issue Jul 8, 2020 · 2 comments · Fixed by #7923
Assignees
@panzarino
Labels
pkg/reporter type: bug type: user experience Improvements needed for UX

Comments

@panzarino
Copy link
Contributor

panzarino commented Jul 8, 2020 •
edited by sync-by-unito bot

Current behavior:

The timeout progress bar will not maintain state when a hook is collapsed and then reopened. This also occurs for opening and closing suites, but not tests (closing a test actually prevents the content from rendering in the DOM, rather than just hiding it).

ezgif-6-7b5bfe0add82

Desired behavior:

The progress bar should reflect the actual progress made and continue to progress as if it was never opened or closed (the same thing that happens with test).

Test code to reproduce

Any failing test
@panzarino panzarino self-assigned this Jul 8, 2020
@panzarino panzarino mentioned this issue Jul 8, 2020
Merged
5 tasks
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review and removed stage: work in progress There is an open PR for this issue [WIP] labels Jul 16, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 20, 2020

The code for this is done in cypress-io/cypress#7923, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Jul 20, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 21, 2020

Released in 4.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.11.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Jul 21, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@panzarino panzarino

Labels
pkg/reporter type: bug type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue where progress bar would restart on collapse toggle cypress-io/cypress
2 participants
@jennifer-shehane @panzarino