Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take Firefox support out of beta; put firefoxGcInterval behind version switch #8241

Closed
flotwig opened this issue Aug 10, 2020 · 2 comments · Fixed by #8586
Closed

Take Firefox support out of beta; put firefoxGcInterval behind version switch #8241

flotwig opened this issue Aug 10, 2020 · 2 comments · Fixed by #8586
Assignees
@flotwig
Labels
browser: firefox

Comments

@flotwig
Copy link
Contributor

flotwig commented Aug 10, 2020 •
edited by sync-by-unito bot

Current behavior:

Cypress FF support is in beta and we always force firefoxGcInterval.

Desired behavior:

Remove beta label from FF support and only require firefoxGcInterval if running Firefox < 80 (check exact version here: https://bugzilla.mozilla.org/show_bug.cgi?id=1608501#c65 )
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Aug 12, 2020
@flotwig flotwig self-assigned this Sep 15, 2020
@flotwig flotwig mentioned this issue Sep 15, 2020
Merged
4 tasks
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review labels Sep 15, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress There is an open PR for this issue [WIP] labels Sep 23, 2020
@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Sep 25, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 25, 2020

The code for this is done in cypress-io/cypress#8586, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 29, 2020

Released in 5.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.3.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Sep 29, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flotwig flotwig

Labels
browser: firefox
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: take Firefox support out of beta cypress-io/cypress
1 participant
@flotwig