Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Issues: Selector playground with long selector does not display correctly / pushes UI off of view #8247

Closed
thomashimanshu opened this issue Aug 11, 2020 · 3 comments · Fixed by #8509
Closed

UI Issues: Selector playground with long selector does not display correctly / pushes UI off of view #8247

thomashimanshu opened this issue Aug 11, 2020 · 3 comments · Fixed by #8509
Labels
good first issue Good for newcomers pkg/runner topic: selector playground 🚸 type: user experience Improvements needed for UX

Comments

@thomashimanshu
Copy link

Screenshot 2020-08-11 at 3 36 51 PM

Current behavior:

Desired behavior:

Test code to reproduce

Versions
@jennifer-shehane
Copy link
Member

jennifer-shehane commented Aug 12, 2020 •
edited

Yah, this is not great. My long selector pushed the top UI off the screen.

The code for this is located here: https://github.com/cypress-io/cypress/blob/develop/packages/runner/src/selector-playground/selector-playground.jsx#L13:L13

Screen Shot 2020-08-12 at 1 36 03 PM

@jennifer-shehane jennifer-shehane changed the title UI Issues: Xpath generator UI Issues: Selector playground with long selector does not display correctly / pushes UI off of view Aug 12, 2020
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Aug 12, 2020
@Jamescan Jamescan mentioned this issue Sep 4, 2020
Merged
@cypress-bot cypress-bot bot added stage: work in progress There is an open PR for this issue [WIP] stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress There is an open PR for this issue [WIP] labels Sep 4, 2020
@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Sep 14, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 14, 2020

The code for this is done in cypress-io/cypress#8509, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 15, 2020

Released in 5.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.2.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Sep 15, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers pkg/runner topic: selector playground 🚸 type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Allow long selectors to scroll in selector playground Jamescan/cypress
2 participants
@jennifer-shehane @thomashimanshu