Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types not supported for retries passed through as test options #8405

Closed
ismail-codinglab opened this issue Aug 25, 2020 · 3 comments · Fixed by #8408
Closed

Types not supported for retries passed through as test options #8405

ismail-codinglab opened this issue Aug 25, 2020 · 3 comments · Fixed by #8408
Assignees
@jennifer-shehane
Labels
type: typings Issue related to Cypress types (for TypeScript)

Comments

@ismail-codinglab
Copy link

ismail-codinglab commented Aug 25, 2020 •
edited by sync-by-unito bot

Current behavior:

image

Desired behavior:

Autocomplete & no errors

Test code to reproduce

  1. install cypress
  2. use typescript
  3. add retries to describe

Versions

v5.0.0
Vscode
@jennifer-shehane jennifer-shehane added the type: typings Issue related to Cypress types (for TypeScript) label Aug 26, 2020
@jennifer-shehane jennifer-shehane changed the title Cypress v5 typescript support for retries Types not supported for retries passed through as test options Aug 26, 2020
@jennifer-shehane jennifer-shehane mentioned this issue Aug 26, 2020
Merged
3 tasks
@cypress-bot cypress-bot bot added the stage: work in progress There is an open PR for this issue [WIP] label Aug 26, 2020
@jennifer-shehane
Copy link
Member

Yah, this was an oversight on release. I've opened a PR here: #8408

@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress There is an open PR for this issue [WIP] labels Aug 26, 2020
@cypress-bot cypress-bot bot added the stage: pending release There is a closed PR for this issue label Aug 27, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 27, 2020

The code for this is done in cypress-io/cypress#8408, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Aug 27, 2020
@bahmutov bahmutov mentioned this issue Sep 1, 2020
Closed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 1, 2020

Released in 5.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.1.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Sep 1, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jennifer-shehane jennifer-shehane

Labels
type: typings Issue related to Cypress types (for TypeScript)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add retries to test config types cypress-io/cypress
2 participants
@jennifer-shehane @ismail-codinglab