Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli should be able to download correct prerelease binary version based on URL #8482

Closed
flotwig opened this issue Sep 2, 2020 · 2 comments · Fixed by #8483
Closed

cli should be able to download correct prerelease binary version based on URL #8482

flotwig opened this issue Sep 2, 2020 · 2 comments · Fixed by #8483
Assignees
@flotwig

Comments

@flotwig
Copy link
Contributor

flotwig commented Sep 2, 2020 •
edited

Current behavior:

Need to specify CYPRESS_INSTALL_BINARY when installing from prerelease .tgz.

Desired behavior:

CYPRESS_INSTALL_BINARY can be autodiscovered if a prerelease .tgz is used.
@flotwig flotwig self-assigned this Sep 2, 2020
@flotwig flotwig mentioned this issue Sep 2, 2020
Merged
2 tasks
@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Sep 3, 2020
@flotwig flotwig mentioned this issue Sep 8, 2020
Merged
@cypress-bot cypress-bot bot added stage: pending release There is a closed PR for this issue and removed stage: needs review The PR code is done & tested, needs review labels Sep 8, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 8, 2020

The code for this is done in cypress-io/cypress#8483, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 15, 2020

Released in 5.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.2.0, please open a new issue.

@cypress-bot cypress-bot bot removed the stage: pending release There is a closed PR for this issue label Sep 15, 2020
@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@flotwig flotwig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): install pre-release binaries by computing binary URL from NPM URL cypress-io/cypress
1 participant
@flotwig