Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing property status in the cypress.run results object #8798

Closed
bahmutov opened this issue Oct 9, 2020 · 2 comments · Fixed by #8799
Closed

Missing property status in the cypress.run results object #8798

bahmutov opened this issue Oct 9, 2020 · 2 comments · Fixed by #8799
Assignees
Labels
topic: npm module api Issues related to using Cypress via its NPM module API type: bug

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Oct 9, 2020

Cypress v5.3.0

In #8604 I have added TypeScript field to set the result of the cypress.run, but did not actually set it in the results object.

Screen Shot 2020-10-08 at 9 50 53 PM

Which affects other tools checking the status like bahmutov/cypress-expect#7

@bahmutov bahmutov self-assigned this Oct 9, 2020
@bahmutov bahmutov added type: bug topic: npm module api Issues related to using Cypress via its NPM module API labels Oct 9, 2020
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Oct 9, 2020
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 19, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 19, 2020

The code for this is done in cypress-io/cypress#8799, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@bahmutov
Copy link
Contributor Author

bahmutov commented Apr 7, 2021

Released in v5.5.0

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: npm module api Issues related to using Cypress via its NPM module API type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant