Skip to content

Chore: remove code around deprecated APIs #8946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jennifer-shehane opened this issue Oct 23, 2020 · 2 comments · Fixed by #8951
Closed

Chore: remove code around deprecated APIs #8946

jennifer-shehane opened this issue Oct 23, 2020 · 2 comments · Fixed by #8951
Labels
type: breaking change Requires a new major release version

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Oct 23, 2020

What would you like?

We want to remove warnings / code around deprecated APIS.

Why is this needed?

  • It's just unnecessary code to maintain.
  • We could potentially reuse these APIs if we want.

Deprecated / Removed values

API Version Removed If used?
cy.privates Long time ago throws warning
cy.props Long time ago throws warning
Cypress.Log.command() Long time ago throws warning
eventually chainer 0.11.0 throws warning
requestJSON prop on XHRs 0.12.0 throws warning
responseJSON prop on XHRs 0.12.0 throws warning
cy.wait(fn) 0.11.4 throws warning
cy.server({stub: false}) 0.13.2 throws warning
cy.server({force404: false }) 0.13.5 now default, throws warning
Cypress.Cookies.get 0.16.0 throws warning
Cypress.Cookies.set 0.16.0 throws warning
Cypress.Cookies.remove 0.16.0 throws warning
Cypress.Cookies.getAllCookies 0.16.0 throws warning
Cypress.Cookies.clearCookies 0.16.0 throws warning
cy.request() failOnStatus 0.18.1 throws warning
cy.agents() 0.18.8 throws warning
cypress ci command 0.19.0 supposed to warn, I'm not sure this even works
CYPRESS_CI_KEY 0.19.0 throws warning
Cypress.addParentCommand() 0.20.0 throws warning
Cypress.addChildCommand() 0.20.0 throws warning
Cypress.addDualCommand() 0.20.0 throws warning
CYPRESS_BINARY_VERSION 3.0.0 throws warning
CYPRESS_SKIP_BINARY_INSTALL 3.0.0 throws warning
screenshotOnHeadlessFailure 3.0.0 throws warning
trashAssetsBeforeHeadlessRuns 3.0.0 throws warning
videoRecording 3.0.0 throws warning

Outside of the scope of this work

We will not be removing code around these deprecated APIs, since there are still some using on versions prior to 4.0.0 that we want to have a good experience when upgrading to our latest version.

API Version Removed If used?
before:browser:launch args 4.0.0 still works, throws deprecation warning
Cypress.Cookies.defaults whitelist 5.0.0 throws warning
blacklistHosts 5.0.0 throws warning
cy.server() whitelist 5.0.0 throws warning
experimentalGetCookiesSameSite 5.0.0 throws warning
experimentalShadowDomSupport 5.2.0 throws warning
@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Oct 26, 2020
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review stage: pending release and removed stage: work in progress labels Oct 26, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 26, 2020

The code for this is done in cypress-io/cypress#8951, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Oct 26, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 24, 2020

Released in 6.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant