Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry proxied requests when network level errors occur #898

Closed
brian-mann opened this issue Nov 9, 2017 · 3 comments
Closed

Retry proxied requests when network level errors occur #898

brian-mann opened this issue Nov 9, 2017 · 3 comments

Comments

@brian-mann
Copy link
Member

@brian-mann brian-mann commented Nov 9, 2017

Need to implement the same kind of retry logic as this lib:

https://github.com/FGRibreau/node-request-retry

['ECONNRESET', 'ENOTFOUND', 'ESOCKETTIMEDOUT', 'ETIMEDOUT', 'ECONNREFUSED', 'EHOSTUNREACH', 'EPIPE', 'EAI_AGAIN']

TODO: research EPIPE we may not be able to retry from that.

@brian-mann
Copy link
Member Author

@brian-mann brian-mann commented Dec 5, 2017

cy.visit, cy.request, and transparently proxied requests should account for this.

IDEA: possibly expose this as global configuration to control the backoff algorithm? Even disable altogether?

retryProxiedRequests: true

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented May 15, 2019

The code for this is done in cypress-io/cypress#4015, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants